Fix wake-from-sleep, RAM overrun, and peripheral hangs in AVR firmware
Three defects prevented the board from working at all: - INT0/INT1 were falling-edge triggered. Edge detection needs the I/O clock, which SLEEP_MODE_PWR_DOWN stops, so neither the reed switch nor the RTC alarm could wake the MCU. Both are now low-level triggered (the only asynchronous mode), and each handler masks its own interrupt while the source is still asserted so the low level cannot retrigger. The reed and RTC pins also get their pull-ups; they were explicitly driven low. - Statics were 1440 B of 2048 with a 538 B main frame, so the first NFC read ran the stack into .data. Shrank the oversized buffers and made the NFC scratch buffer static: statics 1440 -> 1038 B, main frame -> 204 B. - The FIFO was filled after entering TX mode with TxStart = FifoNotEmpty, so transmission began before the payload was loaded. Load in standby. Memory safety: clamp the unvalidated RX length (len - 4 underflowed to >=252 into a 60-byte buffer), fix writes one byte past DATA_BUFFER_65, fix the diameter copy length in st25dv.c, NUL-terminate remove_spaces, and bounds-check the NDEF parser (dropping its tag-sized VLA and its unchecked payload_length decrements). Hangs: add bail-outs to every peripheral poll loop - RFM69 mode/TX/RX waits, the EEPROM WIP poll, all six I2C TWINT spins, and the ADC. The LDO is cut before sleeping, so a slow peripheral hung the firmware with no watchdog armed. Correctness: boot no longer wipes the EEPROM spool; the replayed packet is sent once and deleted only on success; short ATOMIC_BLOCK sections replace the blanket cli() that lost reed pulses during the radio window; the I2C rail comes up before the RTC is touched; sleep_bod_disable() moves into the timed sequence with the sleep race closed; sei() no longer runs inside ISRs; REG_FDEV_MSB was 0x06 twice so deviation was 0; ADC uses return ADC and a /64 prescaler; SS1 is an output before SPE is set. VAL_DATA_MODUL_OOK was misnamed rather than wrong - 0x01 lands in ModulationShaping, not ModulationType - so the register value is unchanged and on-air behavior still matches the base station. Verified: builds clean under -Wall -Wextra on both gnu17 and c23. Not yet run on hardware. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YVJKatfeMJjAmuH9KYiLuv
This commit is contained in:
+7
-9
@@ -17,7 +17,9 @@ extern "C" {
|
||||
#include <stdbool.h>
|
||||
#include <stdlib.h>
|
||||
#include <stdio.h>
|
||||
#define F_CPU 8000000UL // 16 MHz clock speed
|
||||
#ifndef F_CPU
|
||||
#define F_CPU 8000000UL // 8 MHz clock speed; prefer -DF_CPU=8000000UL in the build flags
|
||||
#endif
|
||||
#define BAUD 38400
|
||||
#define F_SCL 200000UL
|
||||
|
||||
@@ -27,14 +29,14 @@ extern "C" {
|
||||
#define MIN(a,b) (((a)<(b))?(a):(b))
|
||||
#define MAX(a,b) (((a)>(b))?(a):(b))
|
||||
|
||||
extern unsigned char DATA_BUFFER_65[64];
|
||||
extern unsigned char DATA_BUFFER_65[65];
|
||||
extern uint8_t DATA_BUFFER_7[7];
|
||||
//extern uint8_t DATA_BUFFER_254[255];
|
||||
extern unsigned char DATA_BUFFER_20[20];
|
||||
|
||||
typedef struct {
|
||||
uint8_t payload_len;
|
||||
char payload[255];
|
||||
char payload[48];
|
||||
uint8_t success;
|
||||
} ndef_message;
|
||||
extern ndef_message NDEF_MSG;
|
||||
@@ -47,8 +49,8 @@ extern trimmed_string_struct TRIMMED_STRING;
|
||||
|
||||
typedef struct {
|
||||
uint8_t name_len;
|
||||
char name_str[128];
|
||||
char diameter_str[128];
|
||||
char name_str[16];
|
||||
char diameter_str[16];
|
||||
uint8_t diameter_len;
|
||||
uint8_t hashed;
|
||||
} identifier_results;
|
||||
@@ -103,10 +105,6 @@ typedef enum // Goes into flags
|
||||
|
||||
|
||||
|
||||
#define WHILE_BREAK(counter, attempts) \
|
||||
counter+=1; \
|
||||
if ((counter+1) > attempts) { break;};
|
||||
|
||||
#ifdef __cplusplus
|
||||
}
|
||||
#endif
|
||||
|
||||
Reference in New Issue
Block a user