Refactor firmware for clarity; no functional changes
- main.c: file-header comment describing the hardware and operation, logic split into named phases (sleep_until_interrupt, wake_peripheral_rails, take_counts_snapshot, send_wheel_counts_report, handle_minute_alarm, init_all_hardware); shared state renamed to say what it is and made static. - rfm69.c: reorganized into six labeled sections; cond_1/2/3 and hash scratch globals replaced by a reply_acknowledges() helper with clear locals; packet layout and every init register write documented. - LOG() macro (compiled out when DO_UART is off) replaces the #if DO_UART blocks that obscured the logic. - Drivers: file-header comments; named RTC_REG_*/RTC_ALM_MASK_BIT constants; EEPROM spool scheme documented; ADC_CHANNEL_BANDGAP named; repeated pin if/else helpers collapsed to SET_PIN_TO(). - Removed unused globals/buffers and commented-out code; ran clang-format with the project style. Register writes and radio protocol are byte-identical. Builds clean under -Wall -Wextra on gnu17 and c23; flash 13028 -> 12830 B, static RAM 1038 -> 999 B. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YVJKatfeMJjAmuH9KYiLuv
This commit is contained in:
+18
-21
@@ -1,4 +1,4 @@
|
||||
/*
|
||||
/*
|
||||
* File: states.h
|
||||
* Author: thebears
|
||||
*
|
||||
@@ -6,39 +6,36 @@
|
||||
*/
|
||||
|
||||
#ifndef STATES_H
|
||||
#define STATES_H
|
||||
#define STATES_H
|
||||
|
||||
|
||||
#include <stdbool.h>
|
||||
#include <avr/io.h>
|
||||
#include <stdbool.h>
|
||||
|
||||
#define SET_PIN_OUT(DDR, PIN) ((DDR) |= (1 << (PIN))) // Set pin as output
|
||||
#define SET_PIN_IN(DDR, PIN) ((DDR) &= ~(1 << (PIN))) // Set pin as input
|
||||
#define SET_PIN_OUT(DDR, PIN) ((DDR) |= (1 << (PIN))) // Set pin as output
|
||||
#define SET_PIN_IN(DDR, PIN) ((DDR) &= ~(1 << (PIN))) // Set pin as input
|
||||
|
||||
#define SET_PIN_HIGH(PORT, PIN) ((PORT) |= (1 << (PIN))) // Set pin high
|
||||
#define SET_PIN_LOW(PORT, PIN) ((PORT) &= ~(1 << (PIN))) // Set pin low
|
||||
#define SET_PIN_HIGH(PORT, PIN) ((PORT) |= (1 << (PIN))) // Set pin high
|
||||
#define SET_PIN_LOW(PORT, PIN) ((PORT) &= ~(1 << (PIN))) // Set pin low
|
||||
|
||||
// Drive a pin to a boolean level
|
||||
#define SET_PIN_TO(PORT, PIN, level) ((level) ? SET_PIN_HIGH(PORT, PIN) : SET_PIN_LOW(PORT, PIN))
|
||||
|
||||
|
||||
#ifdef __cplusplus
|
||||
#ifdef __cplusplus
|
||||
extern "C" {
|
||||
#endif
|
||||
|
||||
void init_spi(void);
|
||||
void rfm69_reset_state(bool state) ;
|
||||
void led_1_set_state(bool state);
|
||||
void init_spi(void);
|
||||
void rfm69_reset_state(bool state);
|
||||
void led_1_set_state(bool state);
|
||||
|
||||
void led_2_set_state(bool state);
|
||||
void led_2_set_state(bool state);
|
||||
|
||||
void led_3_set_state(bool state);
|
||||
void led_3_set_state(bool state);
|
||||
|
||||
void ldo_set_state(bool state);
|
||||
void ldo_set_state(bool state);
|
||||
|
||||
|
||||
|
||||
#ifdef __cplusplus
|
||||
#ifdef __cplusplus
|
||||
}
|
||||
#endif
|
||||
|
||||
#endif /* STATES_H */
|
||||
|
||||
#endif /* STATES_H */
|
||||
|
||||
Reference in New Issue
Block a user